Add a sidebar text-size selector to the terminal toolbar#2288
Open
tomfluff wants to merge 1 commit into
Open
Conversation
The Side Panel terminal renders at a fixed 13px. This adds an xs/sm/md/lg/xl picker in the toolbar (A + dropdown, beside Restart) so users can size the text to their eyes. - sm = 13px is the unchanged default; the others step around it (xs 11, md 15, lg 17, xl 20). Nothing changes until you pick a size. - Persisted in chrome.storage.local, restored on load, applied to the live xterm. - Resize reflows correctly: xterm re-measures the character cell on the next render frame, so the change waits two animation frames before fitAddon.fit() and then sends the new cols/rows to the PTY. Fitting in the same tick reads the old cell and clips the grid until a close/reopen — this avoids that. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GKj8Nr8T4GvryTcWBJRMyC
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an xs / sm / md / lg / xl text-size picker to the Side Panel terminal toolbar (a small
A+ dropdown, next to Restart), so users can size the terminal text to their eyes.Details
sm= 13px is the unchanged default — the others step around it (xs 11, md 15, lg 17, xl 20). Nothing changes visually until a size is picked.chrome.storage.local, restored on load, applied to the live xterm.fitAddon.fit()and then sends the newcols/rowsto the PTY. Fitting in the same tick reads the old cell and clips the grid until a close/reopen — this avoids that (same fit + resize path the first-fit and ResizeObserver already use).Files
extension/sidepanel.html— toolbar<select>extension/sidepanel.css— selector styling (matches the toolbar buttons, dark option list)extension/sidepanel-terminal.js— wiring, persistence, reflowIndependent of #2287 (the Windows CJK-font fix); no overlap.
🤖 Generated with Claude Code