feat: comment categorization (decision/handoff/note types)#2507
Closed
MelsovCOZY wants to merge 4 commits intogastownhall:mainfrom
Closed
feat: comment categorization (decision/handoff/note types)#2507MelsovCOZY wants to merge 4 commits intogastownhall:mainfrom
MelsovCOZY wants to merge 4 commits intogastownhall:mainfrom
Conversation
Adds a `type` VARCHAR(32) column to comments and wisp_comments tables for categorizing comments as decision/handoff/note. Existing comments get empty string (untyped) for backwards compatibility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds comment type constants (decision, handoff, note) and a Type field to the Comment struct for categorizing comments. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Extends AddIssueComment with commentType parameter across all interfaces (Storage, Transaction, AnnotationStore) and implementations - Adds GetIssueCommentsByType for filtered comment retrieval - Updates all callers to pass empty string for backwards compatibility - Adds --type flag to `bd comments add` and `bd comments` list commands - Adds TestTypedComments test covering typed/untyped comments and filtered retrieval - Comment type shown as [type] prefix in human-readable output Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The constant names (CommentTypeDecision, CommentTypeHandoff, CommentTypeNote) are self-documenting. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
Thanks for the contribution! We are going to pass on this one -- comment categorization adds schema migration cost and manual friction (remembering to pass --type) for queries we do not currently make. This also leans toward a Discover, Don't Track violation in our design philosophy -- if we need to distinguish comment types, we would prefer to infer it from content rather than requiring manual annotation. The handoff type specifically overlaps with our existing gt mail handoff protocol. Appreciate the clean implementation and tests though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typecolumn to comments/wisp_comments tables (migration 010)AddIssueCommentwithcommentTypeparameter (all callers updated)GetIssueCommentsByTypefor filtered retrieval--typeflag tobd comments addandbd commentslist commandsTest plan
bd comments add <id> "text" --type decisionstores type correctlybd comments <id> --type decisionfilters by type🤖 Generated with Claude Code