feat: cross-rig prefix routing via routes.jsonl#3047
Closed
maphew wants to merge 4 commits intogastownhall:mainfrom
Closed
feat: cross-rig prefix routing via routes.jsonl#3047maphew wants to merge 4 commits intogastownhall:mainfrom
maphew wants to merge 4 commits intogastownhall:mainfrom
Conversation
…arker) The "Dolt Format" doctor check detected pre-0.56 dolt databases but had no automatic fix — it fell through to the default "No automatic fix available" case. The remedy is trivial: create the .bd-dolt-ok marker file, which is exactly what ensureDoltInit does non-destructively. Add a DoltFormat fix function and wire it into the doctor_fix switch. In server mode the .beads/dolt/.dolt/ directory is vestigial; seeding the marker acknowledges the database without any destructive action. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bd vc commit called store.Commit() which intentionally skips the config table (GH#2455) to prevent sweeping stale config during auto-commits. But bd vc commit is an explicit user action — it should commit everything visible in bd vc status, including config changes from bd config set. Switch to CommitPending which calls CommitWithConfig internally, ensuring all dirty tables including config are committed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The paths are constructed internally from the beads directory, not from user input. Add nolint:gosec annotations matching the rest of the codebase. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bd create auto-commits in embedded mode, so a subsequent bd vc commit may find nothing pending. CommitPending correctly returns committed=false in this case. The test now accepts both outcomes, matching the pattern used by commit_with_message. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Closing this duplicate — approving the original PR #2954 directly instead. Note: rebase will need import additions in routed.go (see review comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #2954 onto upstream/main. Adds cross-rig prefix routing via routes.jsonl with associated doctor and vc behavior updates.
Summary
resolveViaPrefixRoutingto the issue resolution chain (local → prefix routing → contributor auto-routing). When an issue ID has a prefix mapped inroutes.jsonl, it opens the target rig's database to resolve it.bd doctor --fixcan now seed the.bd-dolt-okmarker for pre-0.56 dolt databases.bd vc commitincludes config table: Switches fromCommit()(which skips config) toCommitPending()(which includes config), matching whatbd vc statusshows.Cohesion review
These three changes belong together as a "routing foundation bundle" — the prefix routing is the primary feature, the doctor fix removes a warning that would otherwise fire on rigs that use prefix routing, and the vc commit fix ensures config changes (including routing config) are properly committed.
Test plan
CGO_ENABLED=0 go build ./...)TestInitGuard_FreshCloneWithMetadataJSONalso fails on upstream/main)🤖 Generated with Claude Code