fix: rebind selected workspace before db command startup#3230
Open
julianknutsen wants to merge 5 commits intomainfrom
Open
fix: rebind selected workspace before db command startup#3230julianknutsen wants to merge 5 commits intomainfrom
julianknutsen wants to merge 5 commits intomainfrom
Conversation
Collaborator
Author
|
Tracking down some gnarly rogue dbs in gascity and I think this may be one of the culprits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--dband selector env precedenceBEADS_DIRconfig isolationRoot cause
bdresolved the target workspace for DB commands too late. Global config and ambient caller state could leak into commands targeting another workspace, which let dolt server mode, auto-start settings, and config values come from the caller repo instead of the selected repo.Testing
go test ./cmd/bd -count=1make testgolangci-lint run ./cmd/bd/... ./internal/config/...Notes