fix(nix): use proxy vendor for pure-go package#3491
Merged
maphew merged 1 commit intogastownhall:mainfrom Apr 25, 2026
Merged
Conversation
Build the Nix package with the existing gms_pure_go tag while using proxyVendor to avoid stale vendor/modules.txt consistency checks. Remove the leftover ICU flake wiring and debug env dump from postPatch. Based on the focused Nix changes from gastownhall#3278. Co-authored-by: Patrick Stallings <Patrick.Stallings@gad-inc.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proxyVendorfor the Nix Go module build and update the current-main module hashgms_pure_goNix build tag while removing stale ICU flake wiringenvdump frompostPatchBased on the focused Nix packaging work from #3278, with contributor attribution preserved in the commit.
Validation
scripts/pr-preflight.sh 3278 --repo gastownhall/beads(blocked autonomous replacement/merge because fix(nix): use gms_pure_go, fix vendorHash, drop ICU dependency #3278 is an external contributor PR with a broad diff; used it only as source context)scripts/pr-preflight.sh --search "Nix gms_pure_go vendorHash ICU packaging" --repo gastownhall/beadsgit diff --checkdocker run --rm -v /tmp/tmp.LfkGIl1tTK:/work -w /work nixos/nix:latest nix --extra-experimental-features "nix-command flakes" build path:/work#default --print-build-logsNotes
make testwas attempted and timed out in unrelatedcmd/bdtestTestContextUsesExplicitDBFlagForNoDBCommand; most packages completed.go test -tags gms_pure_go -run "^$" ./cmd/bdthen failed with localdisk quota exceededafter the containerized Nix validation.