fix(close): treat re-close of already-closed issue as idempotent success (GH#4025)#4113
Merged
Merged
Conversation
…ess (GH#4025) When bd close is called on an issue already in closed state within the same wall-clock second, the UPDATE touches no columns and RowsAffected returns 0. Previously this was misinterpreted as "issue not found". Now when RowsAffected==0, query the row's current status: if already closed, return success silently (no duplicate event recorded). If the row truly doesn't exist, preserve the original "issue not found" error. Follows the same idempotent pattern used in claim.go.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Collaborator
Contributor
Author
|
Thanks @harry-miller-trimble! The sqlmock tests for the idempotent path are a nice addition. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4025.
bd close <id>returns "issue not found" when re-closing an already-closed issue within the same wall-clock second. The root cause: the UPDATE touches no columns (status already closed, timestamps identical within the same second), soRowsAffected()returns 0 — previously misinterpreted as "row doesn't exist."Fix
When
RowsAffected == 0, query the row's current status in the same transaction:Follows the same idempotent pattern already used in
claim.go.Test plan
closedevent recorded on re-closebd close $id && bd close $idno longer fail