Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/regression.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,14 @@ jobs:
echo "Changed files:"
printf '%s\n' "$changed"

regression_candidates="$(
printf '%s\n' "$changed" |
grep -Ev '^(cmd/bd|internal/storage|internal/types)/.*_test\.go$' ||
true
)"

risky_pattern='^(\.github/workflows/regression\.yml|Makefile|go\.(mod|sum)|cmd/bd/|internal/storage/|internal/types/|tests/regression/)'
if grep -Eq "$risky_pattern" <<<"$changed"; then
if grep -Eq "$risky_pattern" <<<"$regression_candidates"; then
echo "run_regression=true" >> "$GITHUB_OUTPUT"
echo "reason=PR changes CLI, storage, types, regression, or build inputs" >> "$GITHUB_OUTPUT"
exit 0
Expand Down
91 changes: 91 additions & 0 deletions cmd/bd/metadata_ready_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,3 +92,94 @@ func TestGetReadyWork_MetadataSuite(t *testing.T) {
}
})
}

func TestGetReadyWork_IncludeEphemeralAssigneeIsSuperset(t *testing.T) {
t.Parallel()
tmpDir := t.TempDir()
store := newTestStore(t, tmpDir)
ctx := context.Background()
worker := "control-dispatcher"

issues := []*types.Issue{
{
ID: "mr-assignee-persistent",
Title: "Persistent assigned task",
Priority: 2,
IssueType: types.TypeTask,
Status: types.StatusOpen,
Assignee: worker,
},
{
ID: "mr-assignee-no-history",
Title: "No-history assigned task",
Priority: 2,
IssueType: types.TypeTask,
Status: types.StatusOpen,
Assignee: worker,
NoHistory: true,
},
{
ID: "mr-assignee-ephemeral",
Title: "Ephemeral assigned task",
Priority: 2,
IssueType: types.TypeTask,
Status: types.StatusOpen,
Assignee: worker,
Ephemeral: true,
},
{
ID: "mr-assignee-other",
Title: "Other assigned task",
Priority: 2,
IssueType: types.TypeTask,
Status: types.StatusOpen,
Assignee: "someone-else",
Ephemeral: true,
},
}
for _, issue := range issues {
if err := store.CreateIssue(ctx, issue, "test"); err != nil {
t.Fatalf("CreateIssue(%s): %v", issue.ID, err)
}
}

defaultResults, err := store.GetReadyWork(ctx, types.WorkFilter{
Status: types.StatusOpen,
Assignee: &worker,
})
if err != nil {
t.Fatalf("GetReadyWork default: %v", err)
}
if got := issueIDs(defaultResults); !sameStringSet(got, []string{"mr-assignee-persistent", "mr-assignee-no-history"}) {
t.Fatalf("default ready IDs = %v, want persistent and no-history only", got)
}

allResults, err := store.GetReadyWork(ctx, types.WorkFilter{
Status: types.StatusOpen,
Assignee: &worker,
IncludeEphemeral: true,
})
if err != nil {
t.Fatalf("GetReadyWork include ephemeral: %v", err)
}
if got := issueIDs(allResults); !sameStringSet(got, []string{"mr-assignee-persistent", "mr-assignee-no-history", "mr-assignee-ephemeral"}) {
t.Fatalf("include-ephemeral ready IDs = %v, want persistent, no-history, and ephemeral for assignee", got)
}
}

func sameStringSet(got, want []string) bool {
if len(got) != len(want) {
return false
}
counts := make(map[string]int, len(want))
for _, v := range want {
counts[v]++
}
for _, v := range got {
counts[v]--
if counts[v] < 0 {
return false
}
}
return true
}