Fix #580 PackV2 naming and warning cleanup#856
Conversation
csells
left a comment
There was a problem hiding this comment.
I like that the individual areas of the docs say things like "in this release" or "in this wave". I'd like to see two things change:
-
At the top of every page with a release-specific qualifier, I'd like to see a banner that says something like "This document covers the pre-release version of Gas City v and therefore some of our features are still under active development. You can read the details below." This banner should be clear for the user to see are a separate style from the rest of the docs on the page.
-
I'd like to see each caveat currently marked with "in this release" or "in this wave" or even "in this release wave" to be standardized to be "In this release, ...". Even better if it could easily say "As of release v, ...".
csells
left a comment
There was a problem hiding this comment.
I'm not seeing the things I requested yet in this PR.
| | `[convergence]` | Convergence limits | Keep in `city.toml`. | | ||
| | `[[service]]` | Workspace-owned service declarations | Keep in `city.toml` if they are deployment-owned services. | | ||
| | `[agent_defaults]` | Defaults applied to agents in this city | Lives in both `pack.toml` (pack-wide portable defaults) and `city.toml` (city-level deployment overrides). City layers on top of pack. | | ||
| | `[agent_defaults]` | Defaults applied to agents in this city | Lives in both `pack.toml` (pack-wide portable defaults) and `city.toml` (city-level deployment overrides). City layers on top of pack. In this wave the actively-applied defaults are still narrow: `default_sling_formula` plus `[agent_defaults].append_fragments`. | |
dcf8f9a to
0d8b12a
Compare
|
Addressed the outstanding docs feedback on this branch:
The only code changes after the earlier review loop were the nested |
98bdfd1 to
431d75d
Compare
Merge Conflicts DetectedGitHub reports that this PR currently has merge conflicts with Please rebase your branch against git fetch upstream main
git rebase upstream/main
# resolve conflicts
git push --force-with-leaseWe'll re-review once the conflicts are resolved. |
431d75d to
c2c5385
Compare
c2c5385 to
d688437
Compare
|
Adoption summary for
Proceeding with squash merge. |
Summary
agent_defaultsand prompt-template contracttransitive = falseimports from leaking nested providers, globals, requirements, services, and formula layersFollow-up
agent_defaultssurfaces removed from the tightened docs in Track deferred PackV2 agent-defaults surface removed from current docs #903 (provider,scope,install_agent_hooks)append_fragmentstracked separately in Pack v2: resolve agent-local append_fragments spec/runtime gap #671Testing
go test ./internal/configgo test ./internal/config -run '^(TestImport_TransitiveFalseSuppressesNestedCityImportArtifacts|TestImport_TransitiveFalseSuppressesNestedPackImportArtifacts|TestImport_RigImportTransitiveFalseSuppressesNestedDeps|TestImport_TransitiveFalseSuppressesNestedNamedSessions|TestImport_TransitiveFalseSuppressesLegacyIncludedPackDeps|TestImport_TransitiveFalseSuppressesNestedPackWarnings|TestParseWithMetaSkipsMixedTableWarningWhenCanonicalAndAliasAreDisjoint|TestParseWithMetaSkipsMixedTableWarningWhenOverlapIsOnlyUnsupportedFutureKeys)$' -count=1go test ./cmd/gc -run '^(TestStrictFatalLoadConfigWarningsKeepsMixedTableWarningsFatal)$' -count=1NO BLOCKER OR MAJOR FINDINGS.