Skip to content

Fix #580 PackV2 naming and warning cleanup#856

Merged
julianknutsen merged 43 commits intomainfrom
fix/580-packv2-naming-cleanup
Apr 19, 2026
Merged

Fix #580 PackV2 naming and warning cleanup#856
julianknutsen merged 43 commits intomainfrom
fix/580-packv2-naming-cleanup

Conversation

@julianknutsen
Copy link
Copy Markdown
Collaborator

@julianknutsen julianknutsen commented Apr 19, 2026

Summary

  • align PackV2 docs, schema, and runtime guidance to the current agent_defaults and prompt-template contract
  • preserve imported pack defaults and warning plumbing across config loading, CLI surfaces, and import rewrite paths
  • stop transitive = false imports from leaking nested providers, globals, requirements, services, and formula layers
  • add consistent v0.15.0 pre-release caveat banners and release-qualified wording across the PackV2 docs touched by this rollout

Follow-up

Testing

  • go test ./internal/config
  • go test ./internal/config -run '^(TestImport_TransitiveFalseSuppressesNestedCityImportArtifacts|TestImport_TransitiveFalseSuppressesNestedPackImportArtifacts|TestImport_RigImportTransitiveFalseSuppressesNestedDeps|TestImport_TransitiveFalseSuppressesNestedNamedSessions|TestImport_TransitiveFalseSuppressesLegacyIncludedPackDeps|TestImport_TransitiveFalseSuppressesNestedPackWarnings|TestParseWithMetaSkipsMixedTableWarningWhenCanonicalAndAliasAreDisjoint|TestParseWithMetaSkipsMixedTableWarningWhenOverlapIsOnlyUnsupportedFutureKeys)$' -count=1
  • go test ./cmd/gc -run '^(TestStrictFatalLoadConfigWarningsKeepsMixedTableWarningsFatal)$' -count=1
  • prior Claude branch review major fixed; fresh Codex rerun on the updated diff: NO BLOCKER OR MAJOR FINDINGS.

@github-actions github-actions Bot added the status/needs-triage Inbox — we haven't looked at it yet label Apr 19, 2026
@julianknutsen julianknutsen requested review from csells and donbox April 19, 2026 00:27
Copy link
Copy Markdown
Contributor

@csells csells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that the individual areas of the docs say things like "in this release" or "in this wave". I'd like to see two things change:

  • At the top of every page with a release-specific qualifier, I'd like to see a banner that says something like "This document covers the pre-release version of Gas City v and therefore some of our features are still under active development. You can read the details below." This banner should be clear for the user to see are a separate style from the rest of the docs on the page.

  • I'd like to see each caveat currently marked with "in this release" or "in this wave" or even "in this release wave" to be standardized to be "In this release, ...". Even better if it could easily say "As of release v, ...".

@julianknutsen julianknutsen requested a review from csells April 19, 2026 03:00
Copy link
Copy Markdown
Contributor

@csells csells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing the things I requested yet in this PR.

Comment thread docs/guides/migrating-to-pack-vnext.md Outdated
| `[convergence]` | Convergence limits | Keep in `city.toml`. |
| `[[service]]` | Workspace-owned service declarations | Keep in `city.toml` if they are deployment-owned services. |
| `[agent_defaults]` | Defaults applied to agents in this city | Lives in both `pack.toml` (pack-wide portable defaults) and `city.toml` (city-level deployment overrides). City layers on top of pack. |
| `[agent_defaults]` | Defaults applied to agents in this city | Lives in both `pack.toml` (pack-wide portable defaults) and `city.toml` (city-level deployment overrides). City layers on top of pack. In this wave the actively-applied defaults are still narrow: `default_sling_formula` plus `[agent_defaults].append_fragments`. |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"In this release"

@julianknutsen julianknutsen requested a review from csells April 19, 2026 03:59
@julianknutsen julianknutsen force-pushed the fix/580-packv2-naming-cleanup branch from dcf8f9a to 0d8b12a Compare April 19, 2026 11:04
@julianknutsen
Copy link
Copy Markdown
Collaborator Author

Addressed the outstanding docs feedback on this branch:

The only code changes after the earlier review loop were the nested transitive = false import fix and these docs updates.

@julianknutsen julianknutsen force-pushed the fix/580-packv2-naming-cleanup branch 2 times, most recently from 98bdfd1 to 431d75d Compare April 19, 2026 14:29
@julianknutsen
Copy link
Copy Markdown
Collaborator Author

Merge Conflicts Detected

GitHub reports that this PR currently has merge conflicts with main. Because maintainer edits are disabled on this PR, we cannot rebase or push the conflict resolution to your branch from the adoption workflow.

Please rebase your branch against main and force-push to update this PR:

git fetch upstream main
git rebase upstream/main
# resolve conflicts
git push --force-with-lease

We'll re-review once the conflicts are resolved.

@julianknutsen julianknutsen added the status/needs-info Waiting on you — please reply label Apr 19, 2026
@github-actions github-actions Bot removed the status/needs-info Waiting on you — please reply label Apr 19, 2026
@julianknutsen julianknutsen added status/needs-info Waiting on you — please reply and removed status/needs-triage Inbox — we haven't looked at it yet labels Apr 19, 2026
@julianknutsen julianknutsen force-pushed the fix/580-packv2-naming-cleanup branch from 431d75d to c2c5385 Compare April 19, 2026 22:59
@github-actions github-actions Bot removed the status/needs-info Waiting on you — please reply label Apr 19, 2026
@julianknutsen julianknutsen force-pushed the fix/580-packv2-naming-cleanup branch from c2c5385 to d688437 Compare April 19, 2026 23:07
@julianknutsen
Copy link
Copy Markdown
Collaborator Author

Adoption summary for d68843751646f4e853b0b85ee1eca913804071bd:

  • Rebasing onto current main required conflict resolution across pack config loading, warning emission, CLI config callers, and integration fixtures.
  • Added a fixup commit to preserve fatal unknown-field validation for pack.toml while keeping migration/provenance warnings non-fatal, and cleaned up the remaining lint issues found by CI.
  • Local validation included make lint, go vet ./..., the affected package tests after the final rebase, and a full go test ./... -count=1 -timeout=20m before the final clean rebase. GitHub CI is green on the pushed head.

Proceeding with squash merge.

@julianknutsen julianknutsen merged commit cc304f6 into main Apr 19, 2026
44 checks passed
@julianknutsen julianknutsen deleted the fix/580-packv2-naming-cleanup branch April 19, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants