Skip to content

fix: wrap defer resp.Body.Close() to satisfy errcheck linter#2239

Closed
DreadPirateRobertz wants to merge 1 commit intogastownhall:mainfrom
DreadPirateRobertz:polecat/splendid/hq-7gbd-mm8lmpo9
Closed

fix: wrap defer resp.Body.Close() to satisfy errcheck linter#2239
DreadPirateRobertz wants to merge 1 commit intogastownhall:mainfrom
DreadPirateRobertz:polecat/splendid/hq-7gbd-mm8lmpo9

Conversation

@DreadPirateRobertz
Copy link
Copy Markdown
Contributor

Summary

  • Wraps defer resp.Body.Close() in internal/quota/keychain.go with func() { _ = resp.Body.Close() }() to satisfy the errcheck linter
  • Matches the pattern already used in internal/wasteland/wasteland.go and internal/doltserver/dolthub.go

Test plan

  • go build ./... passes
  • Single-line change, no behavioral difference

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions Bot added the status/needs-triage Inbox — we haven't looked at it yet label Mar 2, 2026
@codecov-commenter
Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
7862 1 7861 35
View the top 1 failed test(s) by shortest run time
github.com/steveyegge/gastown/internal/rig::TestAddRig_UpstreamURL
Stack Traces | 0.06s run time
=== RUN   TestAddRig_UpstreamURL
    manager_test.go:1312: AddRig: Dolt server is not running (required for beads init); start it with 'gt up' or 'gt dolt start'
--- FAIL: TestAddRig_UpstreamURL (0.06s)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@steveyegge
Copy link
Copy Markdown
Collaborator

Closing as duplicate — this fix was already merged in PR #2233. Thanks for the contribution!

@steveyegge steveyegge closed this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/needs-triage Inbox — we haven't looked at it yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants