Skip to content

Fix convoy close dedup after reopen#3215

Closed
seanwessmith wants to merge 2 commits intogastownhall:mainfrom
seanwessmith:codex/convoy-reclose-dedup
Closed

Fix convoy close dedup after reopen#3215
seanwessmith wants to merge 2 commits intogastownhall:mainfrom
seanwessmith:codex/convoy-reclose-dedup

Conversation

@seanwessmith
Copy link
Copy Markdown
Contributor

Summary

  • allow convoy close detection to recover after an issue is reopened and closed again
  • add a 1-second event poll overlap plus lifecycle event-id dedup to handle Dolt's second-precision timestamps without replaying old close events
  • preserve warm-up semantics and add regressions for reopen/reclose across polls and within one poll

Testing

  • go test ./internal/daemon

@github-actions github-actions bot added the status/needs-triage Inbox — we haven't looked at it yet label Mar 24, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 24, 2026

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
9321 4 9317 48
View the top 3 failed test(s) by shortest run time
github.com/steveyegge/gastown/internal/cmd::TestFindWLCommonsFork_NoDoltDir
Stack Traces | 0s run time
=== RUN   TestFindWLCommonsFork_NoDoltDir
=== PAUSE TestFindWLCommonsFork_NoDoltDir
=== CONT  TestFindWLCommonsFork_NoDoltDir
    testing.go:1712: race detected during execution of test
--- FAIL: TestFindWLCommonsFork_NoDoltDir (0.00s)
github.com/steveyegge/gastown/internal/cmd::TestStampLoop_EndToEnd
Stack Traces | 0s run time
=== RUN   TestStampLoop_EndToEnd
=== PAUSE TestStampLoop_EndToEnd
=== CONT  TestStampLoop_EndToEnd
    testing.go:1712: race detected during execution of test
--- FAIL: TestStampLoop_EndToEnd (0.00s)
github.com/steveyegge/gastown/internal/cmd::TestStampLoop_InvalidValence
Stack Traces | 0s run time
=== RUN   TestStampLoop_InvalidValence
=== PAUSE TestStampLoop_InvalidValence
=== CONT  TestStampLoop_InvalidValence
--- FAIL: TestStampLoop_InvalidValence (0.00s)
github.com/steveyegge/gastown/internal/cmd::TestStampLoop_InvalidValence/quality_negative
Stack Traces | 0s run time
=== RUN   TestStampLoop_InvalidValence/quality_negative
    testing.go:1712: race detected during execution of test
--- FAIL: TestStampLoop_InvalidValence/quality_negative (0.00s)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@seanwessmith seanwessmith force-pushed the codex/convoy-reclose-dedup branch from 1225756 to ce41685 Compare March 24, 2026 20:41
@steveyegge
Copy link
Copy Markdown
Collaborator

Fix-merged to main (rebased and pushed directly). Convoy close-reopen-close dedup fix is solid — good edge case handling.

@steveyegge steveyegge closed this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/needs-triage Inbox — we haven't looked at it yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants