fix: resolve rig-scoped mayor/deacon to town-level address (gt-te23)#3291
Merged
steveyegge merged 1 commit intogastownhall:mainfrom Mar 27, 2026
Merged
Conversation
"gastown/mayor" passed validation (workspace dir exists) but mail was never delivered because mayor's inbox uses "mayor/" not "gastown/mayor". Fix: normalizeAddress resolves "<rig>/mayor" → "mayor/" and "<rig>/deacon" → "deacon/" since these are town-level singletons. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
❌ 5 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gt mail send gastown/mayorsilently lost mail — bead created with assigneegastown/mayorbut mayor inbox checksmayor/normalizeAddressnow resolves<rig>/mayor→mayor/and<rig>/deacon→deacon/since these are town-level singletonsChanges
internal/mail/types.go:normalizeAddressresolves 2-part addresses where the second part ismayorordeaconto their town-level canonical forminternal/mail/types_test.go: Added test cases forgastown/mayor,gastown/deacon,laser/mayor,laser/deaconTest plan
go buildpassesgo test ./internal/mail/— all pass including new address resolution testsTestAddressToIdentitycovers all new cases🤖 Generated with Claude Code