fix: skip orphan databases in EnsureAllMetadata to prevent metadata flip-flop#3293
Closed
dannomayernotabot wants to merge 2 commits intogastownhall:mainfrom
Closed
fix: skip orphan databases in EnsureAllMetadata to prevent metadata flip-flop#3293dannomayernotabot wants to merge 2 commits intogastownhall:mainfrom
dannomayernotabot wants to merge 2 commits intogastownhall:mainfrom
Conversation
❌ 5 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
… binaries - Add nolint:unparam to writeTemplate for unused hooksDir parameter - Update TestBuildRefineryPatrolVars_FullConfig to expect judgment_enabled and review_depth vars added to buildRefineryPatrolVars - Add dummy opencode binary to PATH in TestRunHooksSyncNonClaudeAgent so agent resolution doesn't fall back to claude - Add dummy agent binaries to scaffoldWorkspace in doctor tests so template agent sync checks can actually detect non-Claude agents Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…lip-flop
When both an orphan database (e.g., "gastown") and its canonical counterpart
("gt") exist in Dolt, EnsureAllMetadata would process both, writing different
dolt_database values to the same metadata.json. This caused confusing
"identity mismatch repair" warnings that flip-flopped on every startup.
Build a reverse rig→canonical-DB map and skip databases that share a rig's
directory name but aren't the rig's canonical database.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
12c0b70 to
3ae35a8
Compare
Collaborator
|
Superseded by #3287 (fixes the same EnsureAllMetadata oscillation with DB-to-rig grouping) which was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnsureAllMetadataprocesses both and writes differentdolt_databasevalues to the samemetadata.json, causing confusing "identity mismatch repair" warnings that flip-flop on everygt up.Test plan
TestEnsureAllMetadata_SkipsOrphanDatabases— new test passesTestEnsureAllMetadata*tests pass (5/5)gt upno longer shows flip-flop warnings🤖 Generated with Claude Code