fix: use use buildServerSQLCmd() instead of manually constructing the dolt sql command, matching the pattern used by all other internal callers.#3616
Open
steveash wants to merge 1 commit intogastownhall:mainfrom
Conversation
… dolt sql command, matching the pattern used by all other internal callers. Without this, dolt prompts interactively for a password when no password is configured (the default for local servers). Since the subprocess has no TTY, it hangs until timeout, causing gt doctor to falsely report 'database verification failed' even when the server is healthy.
github-actions
bot
added
the
status/needs-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use buildServerSQLCmd() instead of manually constructing the dolt sql command, matching the pattern used by all other internal callers.
Without this, dolt prompts interactively for a password when no password is configured (the default for local servers). Since the subprocess has no TTY, it hangs until timeout, causing gt doctor to falsely report 'database verification failed' even when the server is healthy
Related Issue
N/A
Changes
Testing
go test ./...)Checklist