Extract independent collaterals from #3624 (groq doctor probe, cross-rig routing fix, tmux sentinel, bd bump)#3693
Merged
steveyegge merged 1 commit intomainfrom Apr 20, 2026
Merged
Conversation
Lands the drive-by fixes and additions from #3624 that stand on their own, separate from the speculative nostown/swarm foundation (which remains under review pending a roadmap decision). Included: - internal/beads/beads_agent.go: fix cross-rig routing in CreateAgentBead so polecat agent beads land in the target rig's DB (not the caller's. - internal/config/groq.go: GroqJSONEnforcement constant for groq-compound non-interactive prompts. - internal/doctor/groq_compound_check.go + test: gt doctor probe that verifies groq-compound returns valid JSON when configured. - internal/cmd/doctor.go: register the new check. - internal/tmux/testmain_test.go: sentinel session keeps the tmux test server alive across test runs (fixes stale-socket flakiness). - .github/workflows/nightly-integration.yml: bump bd to v0.57.0. Excluded (under review in #3624): - Swarm hook + SwarmConfig/NonInteractiveConfig types + sling_dispatch.go changes + swarm tests — depend on a nostown binary that is not yet a committed roadmap item. - Refinery manager groq-force-claude guard — silently overrides operator intent; needs separate scrutiny. - cost_tier.go groq preset change — reverts live-key resolution to a sentinel; behavioral change kept out of this split. - internal/cmd/scheduler_integration_test.go rewrites — superseded by main's direct-SQL approach to the crystallizes column issue. Co-authored-by: Keith <37914030+kab0rn@users.noreply.github.com> EOF )
4 tasks
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lands the drive-by fixes and additions from #3624 (kab0rn — "feat: swarm foundation for nostown consensus extension") that stand on their own, separate from the speculative swarm/nostown pieces.
Vibe-maintainer split-merge: the original PR mixes a speculative external-dependency hook (
nostown, not yet a committed roadmap item) with several independently valuable fixes. The clerical work to separate them lives with the maintainer, not the contributor.Included
internal/beads/beads_agent.go— fix cross-rig routing inCreateAgentBeadso polecat agent beads land in the target rig's DB, not the caller's.internal/config/groq.go(new) —GroqJSONEnforcementconstant for groq-compound non-interactive prompts.internal/doctor/groq_compound_check.go(new) + test —gt doctorprobe that verifies groq-compound returns valid JSON when configured.internal/cmd/doctor.go— register the new check.internal/tmux/testmain_test.go— sentinel session keeps the tmux test server alive across test runs (fixes stale-socket flakiness)..github/workflows/nightly-integration.yml— bump bd to v0.57.0.Excluded (held for decision on #3624)
SwarmConfig/NonInteractiveConfigtypes + swarm tests — depend on anostownbinary that is not yet a committed roadmap item.cost_tier.gogroq preset change — reverts live-key resolution to a shell-env sentinel; behavioral change kept out of this split.internal/cmd/scheduler_integration_test.gorewrites — superseded by main's direct-SQL approach to thecrystallizescolumn issue.Test plan
go build ./...passesgo test ./internal/doctor/... ./internal/beads/... ./internal/config/...passesCo-authored-by: Keith 37914030+kab0rn@users.noreply.github.com