Skip to content

Extract independent collaterals from #3624 (groq doctor probe, cross-rig routing fix, tmux sentinel, bd bump)#3693

Merged
steveyegge merged 1 commit intomainfrom
fix/3624-collaterals
Apr 20, 2026
Merged

Extract independent collaterals from #3624 (groq doctor probe, cross-rig routing fix, tmux sentinel, bd bump)#3693
steveyegge merged 1 commit intomainfrom
fix/3624-collaterals

Conversation

@steveyegge
Copy link
Copy Markdown
Collaborator

Summary

Lands the drive-by fixes and additions from #3624 (kab0rn — "feat: swarm foundation for nostown consensus extension") that stand on their own, separate from the speculative swarm/nostown pieces.

Vibe-maintainer split-merge: the original PR mixes a speculative external-dependency hook (nostown, not yet a committed roadmap item) with several independently valuable fixes. The clerical work to separate them lives with the maintainer, not the contributor.

Included

  • internal/beads/beads_agent.go — fix cross-rig routing in CreateAgentBead so polecat agent beads land in the target rig's DB, not the caller's.
  • internal/config/groq.go (new) — GroqJSONEnforcement constant for groq-compound non-interactive prompts.
  • internal/doctor/groq_compound_check.go (new) + test — gt doctor probe that verifies groq-compound returns valid JSON when configured.
  • internal/cmd/doctor.go — register the new check.
  • internal/tmux/testmain_test.go — sentinel session keeps the tmux test server alive across test runs (fixes stale-socket flakiness).
  • .github/workflows/nightly-integration.yml — bump bd to v0.57.0.

Excluded (held for decision on #3624)

  • Swarm hook + SwarmConfig/NonInteractiveConfig types + swarm tests — depend on a nostown binary that is not yet a committed roadmap item.
  • Refinery manager groq-force-claude guard — silently overrides operator intent; needs separate scrutiny.
  • cost_tier.go groq preset change — reverts live-key resolution to a shell-env sentinel; behavioral change kept out of this split.
  • internal/cmd/scheduler_integration_test.go rewrites — superseded by main's direct-SQL approach to the crystallizes column issue.

Test plan

  • go build ./... passes
  • go test ./internal/doctor/... ./internal/beads/... ./internal/config/... passes
  • New groq probe skips cleanly when groq-compound not configured

Co-authored-by: Keith 37914030+kab0rn@users.noreply.github.com

Lands the drive-by fixes and additions from #3624 that stand on their own,
separate from the speculative nostown/swarm foundation (which remains under
review pending a roadmap decision).

Included:
- internal/beads/beads_agent.go: fix cross-rig routing in CreateAgentBead so
  polecat agent beads land in the target rig's DB (not the caller's.
- internal/config/groq.go: GroqJSONEnforcement constant for groq-compound
  non-interactive prompts.
- internal/doctor/groq_compound_check.go + test: gt doctor probe that
  verifies groq-compound returns valid JSON when configured.
- internal/cmd/doctor.go: register the new check.
- internal/tmux/testmain_test.go: sentinel session keeps the tmux test
  server alive across test runs (fixes stale-socket flakiness).
- .github/workflows/nightly-integration.yml: bump bd to v0.57.0.

Excluded (under review in #3624):
- Swarm hook + SwarmConfig/NonInteractiveConfig types + sling_dispatch.go
  changes + swarm tests — depend on a nostown binary that is not yet a
  committed roadmap item.
- Refinery manager groq-force-claude guard — silently overrides operator
  intent; needs separate scrutiny.
- cost_tier.go groq preset change — reverts live-key resolution to a
   sentinel; behavioral change kept out of this split.
- internal/cmd/scheduler_integration_test.go rewrites — superseded by
  main's direct-SQL approach to the crystallizes column issue.

Co-authored-by: Keith <37914030+kab0rn@users.noreply.github.com>
EOF
)
@steveyegge steveyegge merged commit 4c31756 into main Apr 20, 2026
7 of 8 checks passed
@github-actions github-actions bot added the status/needs-triage Inbox — we haven't looked at it yet label Apr 20, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 39.43662% with 43 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/doctor/groq_compound_check.go 41.17% 39 Missing and 1 partial ⚠️
internal/beads/beads_agent.go 0.00% 1 Missing and 1 partial ⚠️
internal/cmd/doctor.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/needs-triage Inbox — we haven't looked at it yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants