test(e2e): add containerized install and daemon tests#558
Closed
easel wants to merge 9 commits intogastownhall:mainfrom
Closed
test(e2e): add containerized install and daemon tests#558easel wants to merge 9 commits intogastownhall:mainfrom
easel wants to merge 9 commits intogastownhall:mainfrom
Conversation
The gt mq list command with --status=open filter was incorrectly displaying CLOSED merge requests as 'ready'. This occurred because bd list --status=open was returning closed issues. Added manual status filtering in three locations: - mq_list.go: Filter closed MRs in all list views - mq_next.go: Skip closed MRs when finding next ready MR - engineer.go: Skip closed MRs in refinery's ready queue Also fixed build error in mail_queue.go where QueueConfig struct (non-pointer) was being compared to nil. Workaround for upstream bd list status filter bug. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Implements two new commands for managing Gas Town processes: 1. gt ps - List all tmux sessions with process information - Shows session names, status (alive/dead), commands, PIDs - Displays work-on-hook status for polecats - Supports --json and --verbose flags - Highlights Gas Town sessions 2. gt cleanup - Manage orphaned processes and sessions - cleanup orphans: Find work assigned to dead agents - cleanup sessions: Clean up dead/zombie tmux sessions - cleanup stale: Clean up stale polecats (wraps gt polecat stale) - Supports --dry-run flag for safe inspection Both commands integrate with existing daemon orphan detection logic and provide manual inspection/triggering of cleanup operations. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Remove --force flag from cleanup sessions command that was declared but never used - Fix extractRigFromAgentID to handle rig names with hyphens by finding the "-polecat-" delimiter - Fix extractPolecatNameFromAgentID to handle polecat names with hyphens by taking everything after "-polecat-" Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The test now uses t.Setenv() which cannot be used with t.Parallel() in Go. This completes the conflict resolution from the rebase.
Add e2e tests that verify gt install creates a functional system: - TestInstallDoctorClean: verifies structure, rig/crew add, commands - TestInstallWithDaemon: extends above with daemon lifecycle testing Tests run in isolated Docker container for reproducibility. Includes: - Dockerfile.e2e for test container - Makefile targets: test-e2e, test-e2e-container - GitHub Actions workflow for CI Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
Closing - need to rebase on upstream main to exclude unrelated fork changes |
Contributor
Author
|
Correctly closed: This PR was rebased to exclude unrelated fork changes and reopened as #559. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gt installcreates a functional systemChanges
TestInstallDoctorClean: verifies structure creation, rig/crew add, basic commandsTestInstallWithDaemon: extends above with daemon lifecycle testingDockerfile.e2e: container for isolated test environmentMakefile: addstest-e2eandtest-e2e-containertargets.github/workflows/e2e.yml: CI workflow for containerized testsTest plan
🤖 Generated with Claude Code