Consistent Statuses for detail view and main table#15
Closed
grantlouisherman wants to merge 1 commit intogastownhall:mainfrom
Closed
Consistent Statuses for detail view and main table#15grantlouisherman wants to merge 1 commit intogastownhall:mainfrom
grantlouisherman wants to merge 1 commit intogastownhall:mainfrom
Conversation
… hover card for pending reviews
7fc608c to
b35755f
Compare
julianknutsen
added a commit
that referenced
this pull request
Mar 6, 2026
- Restore web/dist/.gitkeep (blocker: go:embed requires dist/ to exist) - Remove web/tsconfig.tsbuildinfo and add to .gitignore - Add slog.Debug for toCommitId no-op path in pollOperation - Remove dead stateRank code and simplify best-selection loop - Add keyboard/ARIA accessibility to pending hover card (button + focus-within) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
Merged via maintainer adoption — rebased onto main with 3 fixup commits addressing triple-model review findings:
Thanks for the contribution @grantlouisherman! The status consistency fix and pending hover card are live. 🎉 |
Collaborator
|
Thanks @grantlouisherman! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if you go to the main page, https://wasteland.gastownhall.ai/ you can see a table view and filter. However, there is an inconsistency between the table view and the detail view. For example, "Write public protocol spec (sanitized design.md)" is "In Review" in the table, but open in the detail view https://wasteland.gastownhall.ai/wanted/w-hop-001.
My Changes
Updated UI

Summary of changes:
DoltHub returns HTTP 400 with a toCommitId null error when a write produces no changes (e.g. rig already registered via ON DUPLICATE KEY UPDATE). The polling
code was treating this as a fatal error. Fixed it to treat it as a no-op success, allowing wl join to complete.
The browse list was overlaying item status with the furthest upstream PR state (e.g. an open item showing as in_review because someone had a pending PR). This
caused the filter, list, and detail page to all disagree on status. Removed the status overlay so all three views show the raw DB status consistently.
Replaced the plain title tooltip on the "pending" badge with a hover card showing each competing submission's rig handle, status, and PR/branch link. Required:
Updated two tests that were asserting the old status overlay behavior to reflect the new raw DB status expectation.