websocket headers stream draft - #460
Open
ninaiiad wants to merge 3 commits into
Open
Conversation
ltitanb
approved these changes
Jul 28, 2026
gd-0
requested changes
Jul 28, 2026
| #[derive(Debug, Clone, Copy, Deserialize, Serialize)] | ||
| pub struct HeaderStreamConfig { | ||
| /// How long to stream for, ending at the client's `X-Timeout-Ms` deadline. | ||
| #[serde(default = "default_u64::<500>")] |
Collaborator
There was a problem hiding this comment.
think we can probably tighten this. say to 200-300? what's the max latency we see in practice?
Collaborator
Author
There was a problem hiding this comment.
for the get_header http requests? tail latency is super bad for these, p99 can go up to 2s
ninaiiad
force-pushed
the
ng/ws-get-header
branch
from
July 29, 2026 16:45
971cecf to
ca716f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.