Skip to content

websocket headers stream draft - #460

Open
ninaiiad wants to merge 3 commits into
developfrom
ng/ws-get-header
Open

websocket headers stream draft#460
ninaiiad wants to merge 3 commits into
developfrom
ng/ws-get-header

Conversation

@ninaiiad

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread crates/common/src/config.rs Outdated
Comment thread crates/common/src/config.rs Outdated
#[derive(Debug, Clone, Copy, Deserialize, Serialize)]
pub struct HeaderStreamConfig {
/// How long to stream for, ending at the client's `X-Timeout-Ms` deadline.
#[serde(default = "default_u64::<500>")]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think we can probably tighten this. say to 200-300? what's the max latency we see in practice?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the get_header http requests? tail latency is super bad for these, p99 can go up to 2s

Comment thread crates/relay/src/api/proposer/header_stream.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants