-
Notifications
You must be signed in to change notification settings - Fork 258
Add aws-s3-sdk provider using AWS SDK v2 #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
klaudworks
wants to merge
12
commits into
gaul:master
Choose a base branch
from
klaudworks:feature/aws-s3-sdk-provider
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@gaul it's ready 🥳 |
# Conflicts: # src/test/java/org/gaul/s3proxy/AwsSdkTest.java # src/test/resources/run-s3-tests.sh # src/test/resources/s3proxy-localstack.conf
19ce9ed to
07e62f3
Compare
Contributor
Author
|
I renamed the |
…rt (e.g. Hetzner CEPH)
…g. deployed by Hetzner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adresses: #750
Adds a new
aws-s3-sdkstorage backend using AWS SDK v2, replacing the jclouds-basedaws-s3provider for S3-compatible backends.Changes
AwsS3SdkBlobStoreimplementing full BlobStore interface via AWS SDK v2Changes that I included for my own workloads on s3 compatible storages:
If-Match/If-None-Match) with configurable fallback to an emulation (I need that fallback because lots of s3 compatible storages don't implement that feature yet)I'm using s3proxy as a compatibility layer to be able to swap out s3-compatible storage backends / azure. Even the s3 compatible storage backends are usually not as compatible as it seems. 😅
Current validation
Most s3-tests conformity tests working. Only tests I had to disable were tests
Here the PR for the s3-tests: gaul/s3-tests#5
EDIT 17.12.2025: Running this in kubernetes with quite a wide variety of workloads and it's working just fine.