Fix: Removed duplicate Routes block to prevent redundant rendering#645
Fix: Removed duplicate Routes block to prevent redundant rendering#645gauravsingh1281 merged 1 commit intogauravsingh1281:mainfrom
Conversation
- Eliminated a second Routes block in App.jsx that caused components to render twice. - Ensured that routing logic is handled within the Preloader conditional. - Verified application layout to confirm proper rendering without duplication. - Improved overall code structure and performance by avoiding unnecessary renders.
✅ Deploy Preview for visionary-fenglisu-db1b1d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @Rohitswami16! 🎉 Thank you for submitting your pull request for Rentalog. Our dedicated team will review it diligently.Your contribution is valuable and we appreciate your efforts to improve our project.
|
@gauravsingh1281 Please review the code and merge the PR. Let me know if any changes are required. Thank you |
|
Hey @Rohitswami16 please register yourself in the SWOC OS lead platform so that I can assign you the points. |
|
Thank you for reaching out to me. This is my first time participating in something like this, and I’m very new to the process. Could you please share the registration link or provide guidance on how to register on the SWOC OS Lead platform? I’d appreciate any help or resources you can offer so that I can complete the process and you can assign the points. |
|
Hey @gauravsingh1281 I just wanted to let you know that I’ve registered on the OS Lead platform. Please let me know if there’s anything else I need to do to proceed. |
|
@Rohitswami16 share the screenshot of your profile on OS Lead. |
|
|
|
@Rohitswami16 Done I added the points. |
2 participants
🚀 Pull Request
This pull request resolves issue #644 by removing a redundant Routes block in the App.jsx file. The redundant block was causing components to render multiple times, leading to performance issues and unnecessary complexity in the codebase.
Key Improvements:
Ensured proper routing logic by handling it within the Preloader conditional.
Prevented duplicate component rendering, improving performance and readability.
Verified the application layout to ensure correct behavior and no duplication.
Related Issue
Fixes #644
Type of Change
What kind of change does this pull request introduce?
Screenshots (if applicable)
Before changes
Screen.Recording.2025-01-08.200949.mp4
After changes
Screen.Recording.2025-01-09.000916.mp4
Checklist
Please ensure the following tasks are complete before submitting the pull request: