Skip to content

[bazel] Update Profiler dependency#795

Merged
iche033 merged 2 commits intomainfrom
iche033/profiler_bzl_fix
Mar 20, 2026
Merged

[bazel] Update Profiler dependency#795
iche033 merged 2 commits intomainfrom
iche033/profiler_bzl_fix

Conversation

@iche033
Copy link
Copy Markdown
Contributor

@iche033 iche033 commented Mar 19, 2026

🦟 Bug fix

Summary

Fixes profiler deps as it was found broken in gazebosim/gz-sim#3405 with the following error:

external/gz-common~/profiler/include/gz/common/Profiler.hh:27:10: error: module gz-common~//profiler:profiler does not depend on a module exporting 'gz/utils/NeverDestroyed.hh'

This could be due to recent changes in #779. I was able to reproduce this locally with bazel 8 + clang. This PR adds the NeverDestroyed dep to fix the build issue.

Checklist

  • Signed all commits for DCO
  • Added a screen capture or video to the PR description that demonstrates the fix (as needed)
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • Updated Bazel files (if adding new files). Created an issue otherwise.
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Backports: If this is a backport, please use Rebase and Merge instead.

Signed-off-by: Ian Chen <iche@intrinsic.ai>
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Mar 20, 2026
@iche033 iche033 merged commit 8747e7b into main Mar 20, 2026
13 checks passed
@iche033 iche033 deleted the iche033/profiler_bzl_fix branch March 20, 2026 17:55
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants