feat: Add API for requesting a new mesh from the MeshManager#796
Merged
azeey merged 3 commits intogazebosim:mainfrom Mar 27, 2026
Merged
feat: Add API for requesting a new mesh from the MeshManager#796azeey merged 3 commits intogazebosim:mainfrom
azeey merged 3 commits intogazebosim:mainfrom
Conversation
This allows allocating new `common::Mesh` objects within the gz-common shared library avoiding cross-shared library lifetime mismatch issues. Generated-By: Gemini 3.1 Pro Signed-off-by: Addisu Z. Taddese <addisuzt@intrinsic.ai>
11 tasks
Signed-off-by: Addisu Z. Taddese <addisuzt@intrinsic.ai>
caguero
reviewed
Mar 27, 2026
Contributor
caguero
left a comment
There was a problem hiding this comment.
Looks good besides one minor comment.
My only other question is whether we should deprecate AddMesh() in favor of CreateMesh() or consider to add a comment in AddMesh() about the issue and the option to use CreateMesh().
Signed-off-by: Addisu Z. Taddese <addisuzt@intrinsic.ai>
Contributor
Author
|
I think deprecating |
iche033
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
This allows allocating new
common::Meshobjects within the gz-common shared library avoiding cross-shared library lifetime mismatch issues. Such issues currently cause a segfault in gz-physics COMMON_TEST_collisions_bullet-featherstone test, even though Jenkins doesn't report it (I'm working on a fix for that too).Test it
Run
UNIT_MeshManager_TESTChecklist
codecheckpassed (See contributing)Generated-by: Gemini 3.1 Pro
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.Backports: If this is a backport, please use Rebase and Merge instead.