Remove build RUNPATH from installed libGrid3D.so (backport #676)#745
Open
nim65s wants to merge 1 commit intogazebosim:gz-gui8from
Open
Remove build RUNPATH from installed libGrid3D.so (backport #676)#745nim65s wants to merge 1 commit intogazebosim:gz-gui8from
nim65s wants to merge 1 commit intogazebosim:gz-gui8from
Conversation
Installs libGrid3D.so (a legacy alias for libGridConfig.so) by copying the already installed libGridConfig.so using install(CODE ...) instead of install(FILES ...). This ensures the build directory RUNPATH is correctly stripped, matching other installed plugins. Fixes gazebosim#627 Signed-off-by: shashank1300 <shashankrao1307@gmail.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Guilhem Saurel <guilhem.saurel@laas.fr>
nim65s
force-pushed
the
backport-676-gz-gui-8
branch
from
c154c9c to
88e23a9
Compare
iche033
changed the title
iche033
approved these changes
Feb 21, 2026
azeey
requested changes
Feb 25, 2026
There was a problem hiding this comment.
This is actually causing a cmake warning on homebrew and windows
CMake Warning at src/plugins/grid_config/cmake_install.cmake:68 (message):
Source file for Grid3D (legacy plugin) copy not found, skipping copy:
/opt/homebrew/Cellar/gz-gui8/HEAD/lib/gz-gui-8/plugins/libGridConfig.so
Call Stack (most recent call first):
src/plugins/cmake_install.cmake:45 (include)
src/cmake_install.cmake:43 (include)
cmake_install.cmake:77 (include)
https://build.osrfoundation.org/job/gz_gui-pr-clowin/97/consoleText
https://build.osrfoundation.org/job/gz_gui-ci-pr_any-homebrew-arm64/35/consoleText
Not sure why it's not being caught by Jenkins, but I've also seen it in gz-gui9.
azeey
reviewed
Feb 25, 2026
Comment on lines
+13
to
+16
| if(EXISTS \"\${CMAKE_INSTALL_PREFIX}/${GZ_GUI_PLUGIN_RELATIVE_INSTALL_DIR}/libGridConfig.so\") | ||
| execute_process(COMMAND ${CMAKE_COMMAND} -E copy_if_different | ||
| \"\${CMAKE_INSTALL_PREFIX}/${GZ_GUI_PLUGIN_RELATIVE_INSTALL_DIR}/libGridConfig.so\" | ||
| \"\${CMAKE_INSTALL_PREFIX}/${GZ_GUI_PLUGIN_RELATIVE_INSTALL_DIR}/libGrid3D.so\") |
There was a problem hiding this comment.
I think using ${CMAKE_SHARED_LIBRARY_SUFFIX} might what's needed to avoid the warning on homebrew.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This backport #676 to gz-gui8
Installs libGrid3D.so (a legacy alias for libGridConfig.so) by copying the already installed libGridConfig.so using install(CODE ...) instead of install(FILES ...). This ensures the build directory RUNPATH is correctly stripped, matching other installed plugins.
Fixes #627