Fix TopicEcho_TEST race condition with Publisher_TEST#761
Merged
iche033 merged 1 commit intogazebosim:mainfrom Apr 15, 2026
Merged
Fix TopicEcho_TEST race condition with Publisher_TEST#761iche033 merged 1 commit intogazebosim:mainfrom
iche033 merged 1 commit intogazebosim:mainfrom
Conversation
Both TopicEcho_TEST and Publisher_TEST use the "/echo" topic. When ctest
runs tests in parallel, messages from one test leak into the other,
causing non-deterministic failures.
Use a unique topic name ("/test_topic_echo") in TopicEcho_TEST to avoid
the collision. The Publisher plugin's default topic is "/echo" (which
Publisher_TEST validates), so TopicEcho_TEST is the right one to change.
Generated-by: Claude <noreply@anthropic.com>
Signed-off-by: Taylor Howard <taylorhoward@me.com>
iche033
approved these changes
Apr 15, 2026
Contributor
|
@Mergifyio backport gz-gui10 gz-gui9 gz-gui8 |
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Apr 15, 2026
Both TopicEcho_TEST and Publisher_TEST use the "/echo" topic. When ctest
runs tests in parallel, messages from one test leak into the other,
causing non-deterministic failures.
Use a unique topic name ("/test_topic_echo") in TopicEcho_TEST to avoid
the collision. The Publisher plugin's default topic is "/echo" (which
Publisher_TEST validates), so TopicEcho_TEST is the right one to change.
Generated-by: Claude <noreply@anthropic.com>
Signed-off-by: Taylor Howard <taylorhoward@me.com>
(cherry picked from commit 2f53260)
11 tasks
mergify Bot
pushed a commit
that referenced
this pull request
Apr 15, 2026
Both TopicEcho_TEST and Publisher_TEST use the "/echo" topic. When ctest
runs tests in parallel, messages from one test leak into the other,
causing non-deterministic failures.
Use a unique topic name ("/test_topic_echo") in TopicEcho_TEST to avoid
the collision. The Publisher plugin's default topic is "/echo" (which
Publisher_TEST validates), so TopicEcho_TEST is the right one to change.
Generated-by: Claude <noreply@anthropic.com>
Signed-off-by: Taylor Howard <taylorhoward@me.com>
(cherry picked from commit 2f53260)
11 tasks
mergify Bot
pushed a commit
that referenced
this pull request
Apr 15, 2026
Both TopicEcho_TEST and Publisher_TEST use the "/echo" topic. When ctest
runs tests in parallel, messages from one test leak into the other,
causing non-deterministic failures.
Use a unique topic name ("/test_topic_echo") in TopicEcho_TEST to avoid
the collision. The Publisher plugin's default topic is "/echo" (which
Publisher_TEST validates), so TopicEcho_TEST is the right one to change.
Generated-by: Claude <noreply@anthropic.com>
Signed-off-by: Taylor Howard <taylorhoward@me.com>
(cherry picked from commit 2f53260)
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Both
TopicEcho_TESTandPublisher_TESTuse the/echotopic. When ctest runs tests in parallel (e.g.ctest -j$(nproc)), messages from one test leak into the other, causing non-deterministic failures.This PR uses a unique topic name (
/test_topic_echo) inTopicEcho_TESTby callingSetTopic()beforeOnEcho(true). The Publisher plugin's default topic is/echo(whichPublisher_TESTvalidates), soTopicEcho_TESTis the right one to change.Checklist
codecheckpassed (See contributing)Generated-by: Claude Code
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.