Skip to content

Fix TopicEcho_TEST race condition with Publisher_TEST (backport #761) #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mergify wants to merge 1 commit into
base: gz-gui10
Choose a base branch
from
Open

Fix TopicEcho_TEST race condition with Publisher_TEST (backport #761) #762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/plugins/topic_echo/TopicEcho_TEST.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,14 @@ TEST(TopicEchoTest, GZ_UTILS_TEST_DISABLED_ON_WIN32(Echo))
EXPECT_FALSE(plugin->Paused());

// Start echoing
// Use a unique topic to avoid collisions with Publisher_TEST (whose default
// topic is also "/echo") when tests run in parallel.
plugin->SetTopic("/test_topic_echo");
plugin->OnEcho(true);

// Publish string
transport::Node node;
auto pub = node.Advertise<msgs::StringMsg>("/echo");
auto pub = node.Advertise<msgs::StringMsg>("/test_topic_echo");
msgs::StringMsg msg;
msg.set_data("example string");
pub.Publish(msg);
Expand Down
Loading