Restore support for non-qualified message names#512
Merged
Conversation
Support for non-qualified message names in MessageFactory was removed in #476, but this is not yet supported in gz-transport. Restore the functionality for now to facilitate version bumps and then try removing it later. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
iche033
approved these changes
May 16, 2025
iche033
left a comment
iche033
left a comment
Contributor
There was a problem hiding this comment.
maybe add a comment to mention that we can't remove this deprecation until support in gz-transport is ready
Member
Author
where? in MessageFactory.cc? |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Member
Author
commented in 6be7202 |
Contributor
ah yes that looks good, thanks! |
scpeters
added a commit
that referenced
this pull request
Jun 1, 2025
This reverts commit 08c8340. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
10 tasks
scpeters
added a commit
that referenced
this pull request
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Part of gazebo-tooling/release-tools#1309.
Summary
Support for non-qualified message names in
MessageFactorywas removed in #476, but this is not yet supported in gz-transport (see gazebosim/gz-transport#634). Restore the functionality for now to facilitate version bumps and then try removing it later.Test it
Check CI
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.