Bazel updates: prep for BCR release automation#1196
Merged
iche033 merged 4 commits intogz-rendering10from Dec 11, 2025
Merged
Conversation
Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
Contributor
Author
|
Note: this PR cannot be forward-ported to main automatically since we still want the archive_overrides in MODULE.bazel on that branch. I will open a manual forward port PR once this is merged. |
Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
iche033
approved these changes
Dec 10, 2025
Contributor
Author
|
Windows and Ubuntu Jenkins CI failures are unrelated. |
Contributor
Author
Forward port to main: #1200 |
shameekganguly
added a commit
that referenced
this pull request
Dec 12, 2025
…1196) Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
shameekganguly
added a commit
that referenced
this pull request
Dec 12, 2025
The change had to be amended to apply it on main. Specifically, the repo archive_overrides in MODULE.bazel for gz deps were removed in that PR on the Jetty branch, but we want to preserve it on main to ensure CI uses gz deps from HEAD. -- Original PR description Few small fixes in MODULE.bazel as pre-work to add automation to push new releases to BCR. - Drop repo_name, which removes the need to patch MODULE.bazel when pushing a release to BCR. repo_name is not a required field and can be added on the client side during import if needed to disambiguate packages. - Add compatibility_level to match what is set in BCR - Add buildifier linting for consistent bazel files formatting. - Use cc_library and cc_test from rules_cc, rather than native rules which are deprecated in bazel 9. The buildifier lint target added above already enforces this. - Add module docstring for bazel/gz_rendering_engine_libraries.bzl (enforced by buildifier linting). - Bump rules_cc and rules_gazebo to versions indicated by bazel in the resolved build graph. Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
shameekganguly
added a commit
that referenced
this pull request
Dec 16, 2025
…1196) (#1202) Manually backported to use Ionic packages for gz deps from BCR instead of Jetty deps. -- Original PR description: Few small fixes in MODULE.bazel as pre-work to add automation to push new releases to BCR. - Remove `archive_override` for gazebo package deps and use Jetty packages from BCR instead. As a result, bazel CI will use released versions of gz deps, which is consistent with cmake CI. - Drop `repo_name`, which removes the need to patch MODULE.bazel when pushing a release to BCR. `repo_name` is not a required field and can be added on the client side during import if needed to disambiguate packages. - Add `compatibility_level` to match [what is set in BCR](https://github.com/bazelbuild/bazel-central-registry/blob/928128b1c60e7e32d21ea8bde9fd802674eba5f3/modules/gz-rendering/10.0.0-pre2/MODULE.bazel#L4) - Add `buildifier` linting for consistent bazel files formatting. - Use `cc_library` and `cc_test` from `rules_cc`, rather than native rules which are [deprecated in bazel 9](https://bazel.build/about/roadmap#migration_of_android_c_java_python_and_proto_rules). The buildifier lint target added above already enforces this. - Add module docstring for bazel/gz_rendering_engine_libraries.bzl (enforced by buildifier linting). - Bump `rules_cc` and `rules_gazebo` to versions indicated by bazel in the [resolved build graph](https://github.com/gazebosim/gz-rendering/actions/runs/19647238647/job/56265351330?pr=1196#step:8:19). Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Few small fixes in MODULE.bazel as pre-work to add automation to push new releases to BCR.
archive_overridefor gazebo package deps and use Jetty packages from BCR instead. As a result, bazel CI will use released versions of gz deps, which is consistent with cmake CI.repo_name, which removes the need to patch MODULE.bazel when pushing a release to BCR.repo_nameis not a required field and can be added on the client side during import if needed to disambiguate packages.compatibility_levelto match what is set in BCRbuildifierlinting for consistent bazel files formatting.cc_libraryandcc_testfromrules_cc, rather than native rules which are deprecated in bazel 9. The buildifier lint target added above already enforces this.rules_ccandrules_gazeboto versions indicated by bazel in the resolved build graph.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.