Skip to content

Manual backport of #1243 to gz-rendering9(Close #1248)#1251

Merged
ahcorde merged 1 commit intogazebosim:gz-rendering9from
XINJIANGMO:fix/backport-1243-to-gz-rendering9
Mar 23, 2026
Merged

Manual backport of #1243 to gz-rendering9(Close #1248)#1251
ahcorde merged 1 commit intogazebosim:gz-rendering9from
XINJIANGMO:fix/backport-1243-to-gz-rendering9

Conversation

@XINJIANGMO
Copy link
Contributor

Closes #1248

Summary

This is a manual backport of #1243 to the gz-rendering9 branch.
The conflict occurred because the main branch includes GZ_PROFILE performance profiling macros which do not exist in the gz-rendering9 branch.

delete macro

Test it

Same as the original PR #1243. You can compile the branch and verify that Update() handles the existing renderable properly without duplicate lines.

Checklist

  • Signed all commits for DCO
  • Added a screen capture or video to the PR description that demonstrates the feature
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • Updated Bazel files (if adding new files). Created an issue otherwise.
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.
Backports: If this is a backport, please use Rebase and Merge instead.

…nch functionality (gazebosim#1243)

Signed-off-by: momo <2438833481@qq.com>
@XINJIANGMO XINJIANGMO requested a review from iche033 as a code owner March 23, 2026 14:14
Copilot AI review requested due to automatic review settings March 23, 2026 14:14
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Mar 23, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Manual backport of the fix from #1243/#1248 to prevent Ogre2FrustumVisual::Update() from repeatedly creating and attaching new line renderables, which caused duplicated frustum ray lines over time.

Changes:

  • Reuse the existing Ogre2DynamicRenderable when present instead of always creating a new one.
  • Clear the existing renderable before re-populating points during Update().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@XINJIANGMO XINJIANGMO changed the title Manual backport of #1243 to gz-rendering8(Close #1248) Manual backport of #1243 to gz-rendering9(Close #1248) Mar 23, 2026
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Mar 23, 2026
@ahcorde ahcorde enabled auto-merge (squash) March 23, 2026 14:59
@ahcorde ahcorde merged commit a3319b8 into gazebosim:gz-rendering9 Mar 23, 2026
17 of 20 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Mar 23, 2026
@XINJIANGMO XINJIANGMO deleted the fix/backport-1243-to-gz-rendering9 branch March 24, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants