Manual backport of #1243 to gz-rendering9(Close #1248)#1251
Merged
ahcorde merged 1 commit intogazebosim:gz-rendering9from Mar 23, 2026
Merged
Conversation
…nch functionality (gazebosim#1243) Signed-off-by: momo <2438833481@qq.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Manual backport of the fix from #1243/#1248 to prevent Ogre2FrustumVisual::Update() from repeatedly creating and attaching new line renderables, which caused duplicated frustum ray lines over time.
Changes:
- Reuse the existing
Ogre2DynamicRenderablewhen present instead of always creating a new one. - Clear the existing renderable before re-populating points during
Update().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ahcorde
approved these changes
Mar 23, 2026
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1248
Summary
This is a manual backport of #1243 to the
gz-rendering9branch.The conflict occurred because the
mainbranch includesGZ_PROFILEperformance profiling macros which do not exist in thegz-rendering9branch.delete macro
Test it
Same as the original PR #1243. You can compile the branch and verify that
Update()handles the existing renderable properly without duplicate lines.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.Backports: If this is a backport, please use Rebase and Merge instead.