Skip to content

brew: trust eclipse-zenoh/zenoh#881

Draft
scpeters wants to merge 1 commit into
mainfrom
scpeters/brew_trust_zenoh
Draft

brew: trust eclipse-zenoh/zenoh#881
scpeters wants to merge 1 commit into
mainfrom
scpeters/brew_trust_zenoh

Conversation

@scpeters

Copy link
Copy Markdown
Member

🦟 Bug fix

Follow up to gazebo-tooling/release-tools#1508, fixes gz-transport build

Build Status https://build.osrfoundation.org/view/gz-rotary/job/gz_transport-ci-main-homebrew-arm64/81/

Summary

Homebrew's package descriptions (formulae) are implemented as executable ruby code, which can lead to security issues when using 3rd-party taps, so they have recently added a brew trust command to help mitigate security issues, documented here. Since brew 6.0.0 was released today, it is now required to declare trust for 3rd party taps, either through the brew trust command (done for osrf/simulation in gazebo-tooling/release-tools#1508) or by specifying trust in a Brewfile, which is done here according to the brew documentation.

Backport Policy

  • This is safe to backport to the following versions:
    • Jetty
    • Ionic
    • Harmonic
    • Fortress
  • This should not be backported
  • I am not sure
  • Other (fill in yourself)

Checklist

  • Signed all commits for DCO
  • Added a screen capture or video to the PR description that demonstrates the fix (as needed)
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • Updated Bazel files (if adding new files). Created an issue otherwise.
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Backports: If this is a backport, please use Rebase and Merge instead.

Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
@scpeters

Copy link
Copy Markdown
Member Author

this needs gazebo-tooling/release-tools#1511

@scpeters

Copy link
Copy Markdown
Member Author

@osrf-jenkins run tests please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

2 participants