Skip to content

Fixed windows warning (backport #1595)#1675

Open
mergify[bot] wants to merge 1 commit into
mainfrom
mergify/bp/main/pr-1595
Open

Fixed windows warning (backport #1595)#1675
mergify[bot] wants to merge 1 commit into
mainfrom
mergify/bp/main/pr-1595

Conversation

@mergify

@mergify mergify Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

🦟 Bug fix

Fixes #1593

Summary

std::distince might return a negative value depending on the indexes introduced, but in this case we are always using the begining of the iterator as the first argument. I assume that this will always positive and then the method can always return a unsigned int

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.


This is an automatic backport of pull request #1595 done by [Mergify](https://mergify.com).

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit 7e409b5)

# Conflicts:
#	src/Element.cc
@mergify mergify Bot added the conflicts label Jun 25, 2026
@mergify mergify Bot requested review from azeey and scpeters as code owners June 25, 2026 04:37
@mergify

mergify Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Cherry-pick of 7e409b5 has failed:

On branch mergify/bp/main/pr-1595
Your branch is up to date with 'origin/main'.

You are currently cherry-picking commit 7e409b5d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/Element.cc

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

🧑‍🌾 Element.cc warning in gz-sim10 and gz-sim-main and gz-launch windows

2 participants