Skip to content

Force-remove temp completion file to coexist with alias rm='rm -i'#62

Open
simonm wants to merge 1 commit into
gazorby:mainfrom
simonm:main
Open

Force-remove temp completion file to coexist with alias rm='rm -i'#62
simonm wants to merge 1 commit into
gazorby:mainfrom
simonm:main

Conversation

@simonm
Copy link
Copy Markdown

@simonm simonm commented May 28, 2026

Summary

_fifc removes the temporary completion-list file (created via mktemp) at the end of each invocation using a plain rm $_fifc_complist_path. For users who alias rm to rm -i — a common safety habit — that alias injects an interactive confirmation prompt on every completion, breaking the flow.

This change switches that single call to rm -f, which:

  • Bypasses the -i confirmation an alias would inject.
  • Silently no-ops if the file is already gone, which is harmless here since the path is only used by _fifc itself.

Scope is intentionally minimal: only the cleanup of $_fifc_complist_path in functions/_fifc.fish is touched. No behavior change for users without the alias.

Test plan

  • With alias rm='rm -i' set in fish, trigger fifc completion and confirm no confirmation prompt appears and the temp file is removed.
  • Without the alias, confirm behavior is unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant