Force-remove temp completion file to coexist with alias rm='rm -i'#62
Open
simonm wants to merge 1 commit into
Open
Force-remove temp completion file to coexist with alias rm='rm -i'#62simonm wants to merge 1 commit into
alias rm='rm -i'#62simonm wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_fifcremoves the temporary completion-list file (created viamktemp) at the end of each invocation using a plainrm $_fifc_complist_path. For users who aliasrmtorm -i— a common safety habit — that alias injects an interactive confirmation prompt on every completion, breaking the flow.This change switches that single call to
rm -f, which:-iconfirmation an alias would inject._fifcitself.Scope is intentionally minimal: only the cleanup of
$_fifc_complist_pathinfunctions/_fifc.fishis touched. No behavior change for users without the alias.Test plan
alias rm='rm -i'set in fish, trigger fifc completion and confirm no confirmation prompt appears and the temp file is removed.