Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Resources" section #38

Merged
merged 2 commits into from
Jul 2, 2022
Merged

Add "Resources" section #38

merged 2 commits into from
Jul 2, 2022

Conversation

ISSOtm
Copy link
Member

@ISSOtm ISSOtm commented Jul 1, 2022

Fixes #36

@ISSOtm ISSOtm requested review from avivace and Rangi42 July 1, 2022 20:52
Copy link
Member

@avivace avivace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice!
Pan Docs and the ASM tutorial links should be then removed from the navbar

@ISSOtm ISSOtm requested a review from avivace July 1, 2022 21:18
Copy link
Member

@avivace avivace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ISSOtm Looks better now.

I've also changed the title from the GB ASM Tutorial box to "GB Assembly tutorial". I know that's not techinically the name, but the purpose of the resources box is to have meaningful titles to redirect people to them.

Here's how it looks like now:
image

@ISSOtm
Copy link
Member Author

ISSOtm commented Jul 2, 2022

Yep, fine by me!

@avivace avivace merged commit 4438a2f into gbdev:master Jul 2, 2022
@ISSOtm ISSOtm deleted the resources branch July 2, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RGBDS-structs and hardware.inc should be mentioned in the docs
2 participants