Fix calendar parsing#18
Merged
gburgessiv merged 4 commits intomainfrom Feb 27, 2026
Merged
Conversation
I had to fetch more than 14d to debug
html5ever prints a lot at debug level, filter that.
So the google calendar API says that descriptions _may_ contain HTML, or may be plain text. In practice, it looks like either they're fully HTML, or they're fully plain text. Since I don't feel like writing a shaky "is this HTML" check, just try to parse the description as plain-text, then try as HTML.
Courtesy of Claude
There was a problem hiding this comment.
Pull request overview
This PR fixes calendar event parsing by handling both plain text and HTML descriptions from the Google Calendar API. The main issue was that the API returns descriptions in either format without indication, causing parsing failures.
Changes:
- Refactored
parse_event_description_datato try plain text parsing first, then fall back to HTML conversion if that fails - Added
days_to_fetchCLI parameter with default value of 14 days for configurable event fetching - Updated logger initialization to use the newer builder API and added module-level filtering for
html5ever - Added
PartialEqandEqtrait derives to enable test assertions - Added comprehensive test coverage for plain text, HTML, and edge case scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| calendar_check/src/main.rs | Added configurable days_to_fetch CLI parameter, updated logger to use builder API with module-level filtering |
| calendar_check/src/lib.rs | Refactored parsing to try plain text first then HTML fallback, added trait derives for testing, added 7 new test cases covering various parsing scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.