Skip to content

Unqualify log#19

Merged
gburgessiv merged 1 commit intomainfrom
unqualify-log
Feb 27, 2026
Merged

Unqualify log#19
gburgessiv merged 1 commit intomainfrom
unqualify-log

Conversation

@gburgessiv
Copy link
Copy Markdown
Owner

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates logging usage to import LevelFilter directly, enhances calendar_check configurability by making the fetch window configurable, and improves calendar event description parsing (plain-text vs HTML) with added unit tests.

Changes:

  • Import and use LevelFilter directly instead of qualifying log::LevelFilter.
  • Add --days-to-fetch CLI option to calendar_check and refine logger initialization to reduce noisy module logs.
  • Update description parsing to attempt plain-text first and fall back to HTML-to-text parsing, plus add unit tests for parsing behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
llvm_buildbot_monitor/src/main.rs Unqualifies LevelFilter usage for logger initialization.
calendar_check/src/main.rs Adds days_to_fetch CLI arg and updates logger setup using LevelFilter + module filtering.
calendar_check/src/lib.rs Adds plain-text-first parsing with HTML fallback, derives PartialEq/Eq for test comparisons, and adds parsing tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread calendar_check/src/main.rs
Comment thread calendar_check/src/lib.rs
Comment thread llvm_buildbot_monitor/src/main.rs Outdated
Dunno why I kept these qualified; make them consistently unqualified.
@gburgessiv gburgessiv enabled auto-merge (rebase) February 27, 2026 02:05
@gburgessiv gburgessiv merged commit 59eeaa4 into main Feb 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants