Unqualify log#19
Merged
gburgessiv merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates logging usage to import LevelFilter directly, enhances calendar_check configurability by making the fetch window configurable, and improves calendar event description parsing (plain-text vs HTML) with added unit tests.
Changes:
- Import and use
LevelFilterdirectly instead of qualifyinglog::LevelFilter. - Add
--days-to-fetchCLI option tocalendar_checkand refine logger initialization to reduce noisy module logs. - Update description parsing to attempt plain-text first and fall back to HTML-to-text parsing, plus add unit tests for parsing behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
llvm_buildbot_monitor/src/main.rs |
Unqualifies LevelFilter usage for logger initialization. |
calendar_check/src/main.rs |
Adds days_to_fetch CLI arg and updates logger setup using LevelFilter + module filtering. |
calendar_check/src/lib.rs |
Adds plain-text-first parsing with HTML fallback, derives PartialEq/Eq for test comparisons, and adds parsing tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
09fb5ef to
e8a2c72
Compare
Dunno why I kept these qualified; make them consistently unqualified.
e8a2c72 to
b30fe24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.