Skip to content

Same as #30 but the PR is opened from upstream repository instead of fork#32

Merged
siddharth7113 merged 68 commits into
mainfrom
siddharth/pr-clean
Mar 20, 2026
Merged

Same as #30 but the PR is opened from upstream repository instead of fork#32
siddharth7113 merged 68 commits into
mainfrom
siddharth/pr-clean

Conversation

@siddharth7113

Copy link
Copy Markdown
Collaborator

See PR #30 for more details.

This PR is open to check if ci runs on the repository.

siddharth7113 and others added 28 commits January 22, 2026 17:23
…cript and moved the function to helpers.py and removed the use of numba jit, if the algorithm slows down, we can reintroduce but the fucntion is not complicated to get help from jit compilation:
…to help in understanding the workflow of the program
…generated but manually verified and tested locally on CPU, responsibility for correctness of test lies with @siddharth7113
Accidentaly pushed the LIG.lib file in data/
@siddharth7113

Copy link
Copy Markdown
Collaborator Author

@fkiraly @satvshr Got it, the issue was PR was opened from fork branch not from upstream branch and since upstream already didn;t have tests, and CI , it wouldn't run.

@siddharth7113 siddharth7113 requested a review from fkiraly February 6, 2026 14:47
@siddharth7113

Copy link
Copy Markdown
Collaborator Author

@fkiraly ready for review, tests are working (atleast parts of it) helped me find a bug in structure.py but currently run.py and test_run.py needs to be reviewed.

@siddharth7113

Copy link
Copy Markdown
Collaborator Author

Previous comments in #30

@siddharth7113

Copy link
Copy Markdown
Collaborator Author

@fkiraly I would recommend merging this branch, we might not be able to do complete review of this state of PR, but i have done some black-box testing and the branch is much faster than the current main, and have been tested with 3 different proteins , with good results, we can keep improving things from there on, or revert back if something breaks extensively.

@siddharth7113 siddharth7113 mentioned this pull request Mar 16, 2026
@siddharth7113 siddharth7113 merged commit 242ceaf into main Mar 20, 2026
10 checks passed
@siddharth7113 siddharth7113 deleted the siddharth/pr-clean branch June 12, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants