New Feature: printC #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberixae
force-pushed
the
implement_print_c
branch
from
8d98374 to
3d5209f
Compare
|
I updated the PR based on what seemed to work for me in the json schema converter. It might still problems since I don't use all of the features in the converter. |
|
@gcanti Thanks for this amazing library. It is featuring in ThoughtWorks Radar and that says a lot. Any chance to review this pull request? @cyberixae has done nice JsonSchema2TS codegen using this library. This code is used there, but truly belongs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to implement the
printCfunction that converts a type declaration into codec type signature. This is my best effort of implementing all the features. I'm not sure if all of this works. In particular I'm unsure of how to deal with the recursive and custom types involved. I'm planning to test some of this in practice to see if I can solve some of the problems I have encountered with huge inlined declarations resulting from automated json schema conversion.