Skip to content

Improve file download #3118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JR40159 wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Improve file download #3118

JR40159 wants to merge 13 commits into from

Conversation

@JR40159
Copy link
Member

@JR40159 JR40159 commented Jan 16, 2026

  • Reduce duplication by typing S3 body once in the S3 client and checking that the stream is not null.
  • Help debugging by logging S3 download progress (like upload progress).
  • Improve stream handling by destroying S3 stream when response is closed by client to avoid abnormal behaviour.

PE39806
PE39806 requested changes Jan 19, 2026
View reviewed changes
@JR40159 JR40159 marked this pull request as ready for review January 21, 2026 10:29
PE39806
PE39806 requested changes Jan 21, 2026
View reviewed changes
JRB66955
JRB66955 previously approved these changes Jan 23, 2026
View reviewed changes
PE39806
PE39806 previously requested changes Jan 23, 2026
View reviewed changes
ON93754
ON93754 previously approved these changes Jan 23, 2026
View reviewed changes
@PE39806 PE39806 dismissed stale reviews from ON93754 and JRB66955 via 446627d January 29, 2026 14:36
@PE39806 PE39806 dismissed their stale review January 29, 2026 14:37

Applied suggestion

@PE39806 PE39806 added javascript Pull requests that update Javascript code model artefact management labels Jan 29, 2026
JRB66955
JRB66955 previously approved these changes Jan 30, 2026
View reviewed changes
Copy link
Contributor

@JRB66955 JRB66955 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using instructions outlined within #2774, all working!

ON93754
ON93754 previously approved these changes Feb 2, 2026
View reviewed changes
@PE39806 PE39806 dismissed stale reviews from ON93754 and JRB66955 via 3f7348c February 3, 2026 11:23
@PE39806 PE39806 requested a review from ON93754 February 3, 2026 11:24
@PE39806 PE39806 requested a review from JRB66955 February 3, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JRB66955 JRB66955 JRB66955 approved these changes

@PE39806 PE39806 PE39806 left review comments

@ON93754 ON93754 Awaiting requested review from ON93754

Assignees

No one assigned

Labels

javascript Pull requests that update Javascript code model artefact management

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JR40159 @PE39806 @JRB66955 @ON93754