Skip to content

Bump mongoose to 9.4.x and fix typing/build issues#3687

Open
PE39806 wants to merge 5 commits into
mainfrom
dependency/bump-mongoose-9.4.x
Open

Bump mongoose to 9.4.x and fix typing/build issues#3687
PE39806 wants to merge 5 commits into
mainfrom
dependency/bump-mongoose-9.4.x

Conversation

@PE39806

@PE39806 PE39806 commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

From https://mongoosejs.com/docs/typescript.html

To define a property of type ObjectId, you should use Types.ObjectId in the TypeScript document interface. You should use 'ObjectId' or Schema.Types.ObjectId in your schema definition.

I've had to replace the ReleaseSchema semver string -> object and vice-versa with a new semverString virtual due to newly introduced typing issues.

@github-actions github-actions Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code backend Changes affecting server-side logic, APIs, data processing, or internal services. labels Jun 3, 2026
@github-actions github-actions Bot added the tests Improvements or additions to unit tests and / or end to end tests label Jun 3, 2026
ARADDCC002
ARADDCC002 previously approved these changes Jun 3, 2026
@PE39806 PE39806 marked this pull request as draft June 3, 2026 15:37
@PE39806

PE39806 commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator Author

It looks like the ReleaseModel getter when the semver is a string doesn't behave how I would like. Presumably it is searching by String and not by SemverObject. I'll try and get a neater fix sorted soon.

JRB66955
JRB66955 previously approved these changes Jun 4, 2026
@JRB66955 JRB66955 dismissed their stale review June 4, 2026 10:05

dismiss

@PE39806 PE39806 marked this pull request as ready for review June 12, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Changes affecting server-side logic, APIs, data processing, or internal services. dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code tests Improvements or additions to unit tests and / or end to end tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants