Feature/bai 2511 view all question states#3740
Open
IR96334 wants to merge 13 commits into
Open
Conversation
github-actions
Bot
added
enhancement
GB907762
reviewed
Jun 16, 2026
GB907762
requested changes
Jun 16, 2026
Comment on lines
+254
to
+257
| return requiredByModelState && | ||
| (!schema.requiredByModelStates || !schema.requiredByModelStates.includes(requiredByModelState)) | ||
| ? false | ||
| : true |
Member
There was a problem hiding this comment.
Suggested change
| return requiredByModelState && | |
| (!schema.requiredByModelStates || !schema.requiredByModelStates.includes(requiredByModelState)) | |
| ? false | |
| : true | |
| return Boolean( | |
| requiredByModelState && !(schema.requiredByModelStates && schema.requiredByModelStates.includes(requiredByModelState)), | |
| ) |
Member
Author
There was a problem hiding this comment.
The original version is required for completion bar, but as we are no longer filtering and highlighting it can be used for questions in schema
Co-authored-by: GB907762 <241953074+GB907762@users.noreply.github.com>
Co-authored-by: GB907762 <241953074+GB907762@users.noreply.github.com>
…11-view-all-question-states
github-actions
Bot
added
python
ON93754
reviewed
Jun 22, 2026
ON93754
reviewed
Jun 22, 2026
ON93754
reviewed
Jun 22, 2026
GB907762
requested changes
Jun 23, 2026
PE39806
reviewed
Jun 23, 2026
PE39806
left a comment
PE39806
left a comment
Collaborator
There was a problem hiding this comment.
I think it would also be a good idea to add "requiredByModelStates": ["Review", "Production"], to backend/src/scripts/example_schemas/minimal_model_schema.json (maybe under modelSummary) to demonstrate this feature to new admins from the get-go.
GB907762
requested changes
Jun 23, 2026
| } | ||
|
|
||
| function countQuestionsFromSchema(schema: any): number { | ||
| export function requiredByStateFilter(requiredByModelState?: string, schema?: any) { |
Member
There was a problem hiding this comment.
I don't think schema can be ever undefined
GB907762
reviewed
Jun 24, 2026
| <Box> | ||
| Entries Completed: {formStats.totalAnswers}/{formStats.totalQuestions} | ||
| {toSentenceCase( | ||
| `${requiredByModelState ? `${requiredByModelState} ` : ''}entries completed: ${formStats.totalAnswers}/${formStats.totalQuestions}`, |
Member
There was a problem hiding this comment.
Suggested change
| `${requiredByModelState ? `${requiredByModelState} ` : ''}entries completed: ${formStats.totalAnswers}/${formStats.totalQuestions}`, | |
| `${requiredByModelState ? `${requiredByModelState} ` : ''}fields completed: ${formStats.totalAnswers}/${formStats.totalQuestions}`, |
I know this was like this before but I find entries a confusing term
github-actions
Bot
added
the
documentation
GB907762
force-pushed
the
feature/BAI-2511-view-all-question-states
branch
from
7482b51 to
39e806e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.