Improve python error handling for backend failures#3767
Open
PE39806 wants to merge 5 commits into
Open
Conversation
github-actions
Bot
added
bug
PE39806
removed
the
backend
GB907762
requested changes
Jun 24, 2026
| self.url = url.rstrip("/") + "/api" | ||
| self.agent = agent or Agent() | ||
|
|
||
| def _parse_json(self, res: requests.Response) -> dict[str, Any]: |
Member
There was a problem hiding this comment.
self looks like a redundant parameter. It isn't accessed. Would it be best to add something to Agent.__request
Collaborator
Author
There was a problem hiding this comment.
Good spot. I've opted to make this a @staticmethod rather than moving it into Agent.__request. This avoids changing behaviour for non-JSON responses (e.g. get_download_file) without needing to pass in any extra args or use extra helper functions which might risk this becoming a breaking change.
github-actions
Bot
added
the
backend
PE39806
removed
the
backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this error handling is fully backwards compatible so is not a breaking change.