changes to model details#3775
Conversation
github-actions
Bot
added
javascript
| {response ? ( | ||
| <Stack direction='row' spacing={1}> | ||
| <div>{formatDateStringAsDayMonthAndYear(response.createdAt.toString())} by</div> | ||
| <UserDisplay dn={response.entity} showIcon /> | ||
| </Stack> | ||
| ) : ( | ||
| <em>Error fetching review</em> | ||
| )} |
There was a problem hiding this comment.
I think because this information pertains the model card, it might be better placed at the top of the model card. Instead of on the details. As in Last reviewed by Joe Blogs on 01/01/1970?
Additionally I think Next review due: is irrelevant to a consumer. So maybe a warning at the top of the screen (for expiry) if you are an owner, in the same way we have ones to intact a schema migration might be better.
There was a problem hiding this comment.
I think it takes up too much real estate at the top. The top of the page should really be reserved for the most important information in my opinion, and because the review information is only of interest to either a few people depending on circumstance I think it's better inside Model details
2 participants
No description provided.