Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Extractor to find Bitcoin Addresses in Text #1226

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

homerjonathan
Copy link

Bitcoin Addresses

Added an Operation to Extractors to find Bitcoin Addresses in Text. Since these are very comon in Ransomware it is useful to have the operation. You can write the Regex expression but I feel that this is a valuable function to add. The Regex is fairly smart and should discard many invalid Bitcoin Addresses.

Based on the information found here:

http://mokagio.github.io/tech-journal/2014/11/21/regex-bitcoin.html

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2021

CLA assistant check
All committers have signed the CLA.

@bee-san
Copy link
Collaborator

bee-san commented Aug 21, 2021

This issue looks very similar to what you want:
#1225

@homerjonathan
Copy link
Author

This issue looks very similar to what you want:
#1225

Thanks for your note. I have actually made the change, rather than being a feature request. So the code has been written along with tests. So unsure if I have missed something in your reply?

@homerjonathan
Copy link
Author

With the comment perhaps I haven't been clear in the first description.

I have extended the extractor which seems to be the right place for the improvement. There are extractors for data such as IP Address, MAC address, and dates extractors. I have added a menu for extract Bitcoin addresses. So If you enter an email text for example and it contains a bitcoin address as often included in a Ransomware or Blackmail Scam, the extractor will extract the address and list them. This update includes the code, it has been added onto the menu and has a small number of tests to prove that it works as specified.

@a3957273
Copy link
Member

Hey! This pull request has gotten rather old and that's our fault. This project stopped being actively maintained for a while and it looks like your pull request has started to gather dust. Would you be able to update your branch to the latest version of CyberChef and we'll give it a review?

@homerjonathan
Copy link
Author

Updated with current Master Branch.

@homerjonathan homerjonathan reopened this Feb 16, 2025
@homerjonathan
Copy link
Author

Test has failed. Will need to investigate what has changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants