Skip to content

dish: properly serialize Javascript Maps as JSON #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

dish: properly serialize Javascript Maps as JSON #1245

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9abc18
dish: properly serialize Javascript Maps as JSON
t-8ch Sep 17, 2021
7ba6328
Merge branch 'master' into json-map
a3957273 Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/core/dishTypes/DishJSON.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,17 @@
import DishType from "./DishType.mjs";
import Utils from "../Utils.mjs";

/**
* Serialize Maps which are not natively compatible with JSON as an array of
* key-value-paris.
*/
function jsonStringifyReplacer(k, v) {
if (v instanceof Map) {
return [...v];
}
return v;
}

/**
* Translation methods for JSON dishes
*/
Expand All @@ -17,7 +28,7 @@ class DishJSON extends DishType {
*/
static toArrayBuffer() {
DishJSON.checkForValue(this.value);
this.value = this.value !== undefined ? Utils.strToArrayBuffer(JSON.stringify(this.value, null, 4)) : new ArrayBuffer;
this.value = this.value !== undefined ? Utils.strToArrayBuffer(JSON.stringify(this.value, jsonStringifyReplacer, 4)) : new ArrayBuffer;
}

/**
Expand Down
Loading