SMS encoding/decoding #1293
Open
SMS encoding/decoding #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl5193
reviewed
Jan 19, 2022
| @@ -63,7 +63,9 @@ | |||
| "JSON to CSV", | |||
| "Avro to JSON", | |||
| "CBOR Encode", | |||
| "CBOR Decode" | |||
| "CBOR Decode", | |||
| "From GSM-7", | |||
There was a problem hiding this comment.
Please fix indentation - always use spaces, not tabs
|
Hey! This pull request has gotten rather old and that's our fault. This project stopped being actively maintained for a while and it looks like your pull request has started to gather dust. Would you be able to update your branch to the latest version of CyberChef and we'll give it a review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Here is a proposition for 2 new operations: encoding/decoding of SMS according to the GSM-7 standard currently in use in our mobile phones (whether SMS is sent over NAS or over IP).
The 11 tests are running OK. But the operations are not working in the GUI. Can you tell me if this is worth trying to fix the issue? In other words, are you willing to accept those new operations when they are ready? I am asking because they may be out of the scope of CyberChef, a bit too "telco".