add Protobuf Stream Decode operation #1384
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
oliverrahner
force-pushed
the
protobufstreamdecode
branch
from
acd2e72 to
2316b77
Compare
|
This would be very helpful to have, why isn't it merged yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new operation for Protobuf Stream Decoding. Streaming basically concatenates multiple protobuf objects, each prepended with its VarInt encoded length.
I have yet to think of a creative way to enable adding schemas for the streamed objects, because there is no (elegant) way to assign message types to each respective object.
For the same reason, I didn't add an Encode operation.