Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new operation: Insert bytes #1492

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

DidierStevens
Copy link
Contributor

This is a new operation to insert bytes at an arbitrary position.
Option 'from end' means that the position is given from the end of the data buffer in stead of the start of the data buffer.
Option 'overwrite' means that the bytes to be inserted, overwrite existing bytes.

@DidierStevens
Copy link
Contributor Author

OK, I made a mistake, I also pushed changes to the Change IP Format operation, added Little Endian support for input and output of decimal and octal numbers.
If you don't want both commits in the same PR, let me know.

@a3957273
Copy link
Member

Hey! This pull request has gotten rather old and that's our fault. This project stopped being actively maintained for a while and it looks like your pull request has started to gather dust. Would you be able to update your branch to the latest version of CyberChef and we'll give it a review?

@DidierStevens DidierStevens reopened this Feb 16, 2025
@DidierStevens
Copy link
Contributor Author

OK, no worries, I updated.

@a3957273
Copy link
Member

Hey, you seem to have changed the order of test/operations/index.mjs. Could you keep the same alphabetic order it was in initially?

@DidierStevens
Copy link
Contributor Author

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants