Fixed stepping through a recipe with disabled operations or comments#1550
Open
brun0ne wants to merge 3 commits into
Open
Fixed stepping through a recipe with disabled operations or comments#1550brun0ne wants to merge 3 commits into
brun0ne wants to merge 3 commits into
Conversation
brun0ne
changed the title
Addresses review feedback on gchq#1550.
C85297
previously approved these changes
Jul 6, 2026
C85297
left a comment
C85297
left a comment
Member
There was a problem hiding this comment.
Thank you for the pull request! I've updated it slightly - the submitted code could result in comments changing the processed data input type as Recipe.execute would call dish.get(op.inputType) on comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently disabling any operation (or adding a
Comment- fixes #1508) results in the step button not working correctly.It can be fixed by skipping these operations inside
bake().Setting the
disabledparameter in theRecipeclass does not seem to be necessary after this change, so I removed it.With this fix, stepping treats disabled operations and
Commentsas if they were not there at all.