Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Generate UUID" and "Analyse UUID" operations #2011

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

bartvanandel
Copy link

This is an update to the (closed, but unmerged) #1531, now with additional support for UUID v6 and v7.

Fixes #1216

@CLAassistant
Copy link

CLAassistant commented Apr 3, 2025

CLA assistant check
All committers have signed the CLA.

@bartvanandel bartvanandel force-pushed the feat/1216-1531-upgrade-uuid branch from 7e7971a to de5b03f Compare April 4, 2025 08:24
@a3957273
Copy link
Member

a3957273 commented Apr 5, 2025

Hey! UUID is one of our most used operations, so commits to make it even better are much appreciated. Is there any chance we can keep the default as UUIDv4? A lot of people have preset scripts that go to, e.g:

/#recipe=Generate_UUID()

And I don't to break backwards compatibility given how often this is used.

@bartvanandel
Copy link
Author

bartvanandel commented Apr 5, 2025

@a3957273 I've added defaultIndex, as well as a unit test to ensure it works correctly. Ran into an issue there however, causing the unit test to fail, see #2015 for a fix. Other than that, it works.

I also simplified the argument names a bit by moving most of the info to the hint properties.

Looks like those aren't rendered correctly for option and string fields at the moment though. I ran $('[data-toggle=tooltip]').tooltip() from the Developer Console, which does change the DOM, but no tooltips are being displayed in Safari or Chrome (both on MacOS). Looks like this should run automatically, which it doesn't either. I'll see if I can find out how to fix this, but that's going to be another PR for sure.

@bartvanandel
Copy link
Author

Looks like those aren't rendered correctly for option and string fields at the moment though. I ran $('[data-toggle=tooltip]').tooltip() from the Developer Console, which does change the DOM, but no tooltips are being displayed in Safari or Chrome (both on MacOS). Looks like this should run automatically, which it doesn't either. I'll see if I can find out how to fix this, but that's going to be another PR for sure.

Investigated and fixed here: #2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Support UUIDv5
4 participants