Fix(RecipeWaiter): sanitize user input in addOperation to prevent XSS #2014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix Description:
innerHTML
directly introduces a potential XSS vulnerability by allowing injection of malicious code.Behavior Before
output.mp4
Behavior After (fix):
output.mp4
Producing the issue:
https://gchq.github.io/CyberChef#recipe=%3Cimg_src%3dx_onerror%3d'alert%601%60'/%3E('Space',false)Generate_all_hashes()&input=MzA1MTczMTA5
https://gchq.github.io/CyberChef#recipe=%3Cimg_src%3dx_onerror%3d'confirm%601%60'/%3E('Space',false)Generate_all_hashes()&input=test