Update JIMP #2171
Open
Update JIMP #2171
+1,016
−949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "maxBOF": 0 | ||
| }], | ||
| "no-whitespace-before-property": "error", | ||
| "operator-linebreak": ["error", "after"], |
Contributor
There was a problem hiding this comment.
Not convinced this is the right fix.
The "operator goes at the end of the line, even for ternary operators" convention has been used throughout the rest of the codebase.
Probably therefore better to fix the "errors" this change has thrown up rather than changing/removing the convention (though, presumably like you, I'm not convinced it's the convention I'd have selected at the outset).
Member
Author
There was a problem hiding this comment.
Yes you're right - laziness on my part since I couldn't work out how to change my editors behaviour :D I'll sort this out once I get the tests working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.