Fix MD2 rounds validation#2526
Open
marko1olo wants to merge 1 commit into
Open
Conversation
Reject negative and fractional MD2 round counts before passing the option into the hash implementation. This prevents negative rounds from producing an all-zero digest while preserving zero and positive integer round counts. Co-authored-by: OpenAI Codex <codex@openai.com>
|
|
Contributor
|
Please could you sign the CLA as we are unable to accept contributions unless this is done (applies to your other PRs too, although you will only need to sign the CLA once) |
Contributor
|
As we are unable to accept contributions unless the CLA has been signed, this PR will be automatically closed if the CLA is not signed within 21 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2506.
Summary
roundsoption before invoking the hash implementation.OperationErrorinstead of producing invalid output.Tests
node --no-warnings --no-deprecation --openssl-legacy-provider tests/operations/index.mjsnpx eslint src/core/operations/MD2.mjs tests/operations/tests/Hash.mjsnpx grunt configTestsgit diff --checkThis change was prepared with OpenAI Codex.